Fix various Fatal Flourish interactions#9723
Open
Peechey wants to merge 6 commits intoPathOfBuildingCommunity:devfrom
Open
Fix various Fatal Flourish interactions#9723Peechey wants to merge 6 commits intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 6 commits intoPathOfBuildingCommunity:devfrom
Conversation
Peechey
changed the title
LocalIdentity
added
bug: calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9722
Fixes #9724
Description of the problem being solved:
The parsing for Fatal Flourish only looked for the Attack modflag, this PR updates the lines to ignore SkillType Travel and Retaliation on top of that. I'm basing the Retaliation off patch 3.25.1 hotfix 2 https://www.pathofexile.com/forum/view-thread/3560601 and Travel skills should never have been supported from the beginning.
Update 1: adding skillType checks for Instant, Channel, and Triggered (Combust, General's Cry etc). Haven't accounted for Trap/Mine mana cost. I'm not certain the DPS changes from what it currently calculates.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: